-
Notifications
You must be signed in to change notification settings - Fork 657
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Optical channel reference to it's logical channel #1130
Conversation
…ew_types git pull latest
channel assignment
@ahsaanyousaf @dplore could you please help review? Thanks. |
/gcbrun |
No major YANG version changes in commit 8811035 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good to me from a model and use case perspective. Is there any evidence of implementation of this mapping?
Unfortunately, I don't know of any vendor implementations that tried to do an augment for this. For an internal project (DCGate) there are performance concerns as the current leaf that maps logical channels to optical channels (i.e. opposite direction) you could have something that kind of starts to look like an N^2 problem (with hundreds of logical channels, each with a handful of logical-channel-assignments) because to find the logical channel that maps to a specific optical channel would require looping through every assignment. With this approach, it becomes a simple targeted lookup. |
Hi Darren, as suggested, here is a pyang output showing the new 'logical-channel-assignment' leaf. Please let me know if I can provide anything else. Thanks. module: openconfig-platform |
/gcbrun |
Last call for comments. To be merged on July 29, 2024 |
* Add a state leaf to optical channels to reference their logical channel assignment
* Add a state leaf to optical channels to reference their logical channel assignment
New leafref added:
/components/component/optical-channel/state/logical-channel-assignment
More details at:
#1128
Tree output