Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adding deviation for cisco delimiter, and skipping empty string #3756

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

fmolinar
Copy link
Contributor

@fmolinar fmolinar commented Feb 7, 2025

Adding the deviation for the banner test as Cisco devices expect a delimiter to be sent, and skipping the empty string banner test since Cisco currently doesnt support empty string send as banner.

@fmolinar fmolinar requested a review from a team as a code owner February 7, 2025 23:16
@OpenConfigBot
Copy link

OpenConfigBot commented Feb 7, 2025

Pull Request Functional Test Report for #3756 / 1a32a6e

Virtual Devices

Device Test Test Documentation Job Raw Log
Arista cEOS status
System-1: System testing
Cisco 8000E status
System-1: System testing
Cisco XRd status
System-1: System testing
Juniper ncPTX status
System-1: System testing
Nokia SR Linux status
System-1: System testing
Openconfig Lemming status
System-1: System testing

Hardware Devices

Device Test Test Documentation Raw Log
Arista 7808 status
System-1: System testing
Cisco 8808 status
System-1: System testing
Juniper PTX10008 status
System-1: System testing
Nokia 7250 IXR-10e status
System-1: System testing

Help

feature/system/tests/system_base_test/banner_test.go Outdated Show resolved Hide resolved
feature/system/tests/system_base_test/banner_test.go Outdated Show resolved Hide resolved
feature/system/tests/system_base_test/banner_test.go Outdated Show resolved Hide resolved
feature/system/tests/system_base_test/banner_test.go Outdated Show resolved Hide resolved
@fmolinar fmolinar requested a review from a team as a code owner February 10, 2025 23:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants