SAI proposal for Synchronous Ethernet #2146
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: rpmarvell <[email protected]>
kcudnik
reviewed
Mar 3, 2025
Comment on lines
+5215
to
+5220
| if (SAI_OBJECT_TYPE_SYNCE == oi->objecttype) | ||
| { | ||
| META_LOG_WARN("synce object %s not present on any object list (eg. VLAN_MEMBER is present on SAI_VLAN_ATTR_MEMBER_LIST)", oi->objecttypename); | ||
| return; | ||
| } | ||
|
|
There was a problem hiding this comment.
why this exception is made ? seems like your objects are not SET on any attributes that's why you are getting this error, why you dont set it on any other attributes ?
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This proposal introduces Synchronous Ethernet(SyncE) to SAI with following details,