Switch SER Callback and Log Info #1307
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jai Kumar <[email protected]>
Signed-off-by: Jai Kumar <[email protected]>
kcudnik
reviewed
Sep 15, 2021
Signed-off-by: Jai Kumar <[email protected]>
| */ | ||
| SAI_SWITCH_SOFT_ERROR_TYPE_ECC_DOUBLE_BIT = 3, | ||
|
|
||
| /** |
There was a problem hiding this comment.
Is this meant to be "all other soft error types"? If so, how does it differ from UNKNOWN? (if not, what is it?)
kcudnik
reviewed
Sep 22, 2021
kcudnik
reviewed
Sep 22, 2021
kcudnik
reviewed
Sep 22, 2021
|
please fix errors |
kcudnik
reviewed
Sep 23, 2021
| /** | ||
| * @brief Soft error recovery log info flags | ||
| */ | ||
| sai_switch_ser_log_t flags; |
There was a problem hiding this comment.
should this be uint32_t if this will be combination of flags ? currently we have similar thing in stats_mode flags
There was a problem hiding this comment.
lguohan
reviewed
Sep 23, 2021
| /** | ||
| * @brief Memory needs special correction handling | ||
| */ | ||
| SAI_SWITCH_CORRECTION_TYPE_SPECIAL = 5, |
There was a problem hiding this comment.
can you clarify if error is corrected or not?
kcudnik
reviewed
Sep 24, 2021
| @@ -5124,6 +5124,7 @@ void check_enum_range_base( | |||
|
|
|||
| SKIP_ENUM(sai_attr_flags_t); | |||
| SKIP_ENUM(sai_stats_mode_t); | |||
| SKIP_ENUM(sai_switch_ser_log_t); | |||
There was a problem hiding this comment.
no need for this change, i updated sainitycheck to use flags enum type
kcudnik
reviewed
Sep 24, 2021
| * | ||
| * Note enum values must be powers of 2 to be used as bit mask | ||
| * | ||
| * @flags Contains flags |
There was a problem hiding this comment.
you will need to change this to "@flags strict"
| * @param[in] count Number of notifications | ||
| * @param[in] data Array of soft error recovery event types | ||
| */ | ||
| typedef void (*sai_switch_ser_event_notification_fn)( |
There was a problem hiding this comment.
Should this include the switch_id in the callback?
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Memory corruption can be classified into two buckets. One is hard failure and the other is soft failure. Soft failure/error is tend to cause by a single event upset (SEU) to the data memory. Hard failure is tend to be the result of raw defects in silicon wafer, natural aging or electrical over stress causing the P/N junction to break down permanently. Soft error is opposite from hard failure, that is, the memory corruption will go away after the device is reset or re- initialized.
This PR introduces a callback for Soft Error and Recovery mechanism and associated recovery type and log information.