Fix dc example #567
Merged
Fix dc example #567
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Alive Statistics: 64 / 93 (29 failed) |
|
Alive Statistics: 64 / 93 (29 failed) |
|
|
||
| def remNone (lst : List (Option Bool)) : List (Option Bool) := | ||
| lst.filter (fun | some x => true | ||
| | none => false) | ||
|
|
||
|
|
There was a problem hiding this comment.
This is unrelated. Maybe not include this in this commit.
| }] | ||
|
|
||
|
|
There was a problem hiding this comment.
This is unrelated. Maybe not include this in this commit.
| @@ -208,7 +208,6 @@ def mkTy2 : String → MLIR.AST.ExceptM (DC) Ty2 | |||
| | "Bool" => return (.bool) | |||
| | _ => throw .unsupportedType | |||
|
|
|||
|
|
|||
tobiasgrosser
approved these changes
Aug 26, 2024
|
Also, you may want to update the commit message to include @ymherklotz's analysis. |
Co-authored-by: Tobias Grosser <[email protected]>
| @@ -3,24 +3,22 @@ import SSA.Core.MLIRSyntax.GenericParser | |||
| import SSA.Projects.CIRCT.DC | |||
| import SSA.Projects.CIRCT.DC.Stream | |||
|
|
|||
|
|
|||
|
|
|||
|
Alive Statistics: 64 / 93 (29 failed) |
|
Alive Statistics: 64 / 93 (29 failed) |
ymherklotz
approved these changes
Aug 27, 2024
AtticusKuhn
pushed a commit
that referenced
this pull request
Sep 2, 2024
Function `splitOn` is defined using `splitOnAux`, which is defined by well-founded recursion and marked @[irreducible] by default. As [advised](leanprover/lean4#4061), we set `splitOnAux` back to semireducible by using `unseal` to use it in `DCExample`. CC: @ymherklotz @alexkeizer --------- Co-authored-by: Tobias Grosser <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Function
splitOnis defined usingsplitOnAux, which is defined by well-founded recursion and marked @[irreducible] by default. As advised, we setsplitOnAuxback to semireducible by usingunsealto use it inDCExample. CC: @ymherklotz @alexkeizer