Release 1.2.0

[amihaiemil]

Let's release version 1.2.0, it contains numerous refactorings, bugfixes and the new driver option (configurable in .charles.yml) which lets you choose between phantomjs and chrome as the crawling tool.

[amihaiemil]

@rultor release it, tag is 1.2.0

[rultor]

@rultor release it, tag is 1.2.0

@amihaiemil OK, I will release it now. Please check the progress here

[rultor]

@rultor release it, tag is 1.2.0

@amihaiemil Oops, I failed. You can see the full log here (spent 3min)

[ERROR] /home/r/repo/src/main/java/com/amihaiemil/charles/rest/CharlesResource.java:101: warning: no @param for secret
[ERROR] public CharlesResource (
[ERROR] ^
[ERROR] /home/r/repo/src/main/java/com/amihaiemil/charles/rest/CharlesResource.java:101: warning: no @param for reg
[ERROR] public CharlesResource (
[ERROR] ^
[ERROR] /home/r/repo/src/main/java/com/amihaiemil/charles/rest/CharlesResource.java:101: warning: no @param for es
[ERROR] public CharlesResource (
[ERROR] ^
[ERROR] /home/r/repo/src/main/java/com/amihaiemil/charles/rest/LogsResource.java:49: warning: no @param for name
[ERROR] public Response getActionLogs(@PathParam("name") String name) {
[ERROR] ^
[ERROR] /home/r/repo/src/main/java/com/amihaiemil/charles/rest/NotificationsResource.java:125: error: unexpected text
[ERROR] * @see https://developer.github.com/v3/activity/events/types/#webhook-event-name-13
[ERROR] ^
[ERROR] /home/r/repo/src/main/java/com/amihaiemil/charles/rest/NotificationsResource.java:131: warning - Tag @see:illegal character: "58" in "https://developer.github.com/v3/activity/events/types/#webhook-event-name-13"
[ERROR] /home/r/repo/src/main/java/com/amihaiemil/charles/rest/NotificationsResource.java:131: warning - Tag @see:illegal character: "47" in "https://developer.github.com/v3/activity/events/types/#webhook-event-name-13"
[ERROR] /home/r/repo/src/main/java/com/amihaiemil/charles/rest/NotificationsResource.java:131: warning - Tag @see:illegal character: "47" in "https://developer.github.com/v3/activity/events/types/#webhook-event-name-13"
[ERROR] /home/r/repo/src/main/java/com/amihaiemil/charles/rest/NotificationsResource.java:131: warning - Tag @see:illegal character: "47" in "https://developer.github.com/v3/activity/events/types/#webhook-event-name-13"
[ERROR] /home/r/repo/src/main/java/com/amihaiemil/charles/rest/NotificationsResource.java:131: warning - Tag @see:illegal character: "47" in "https://developer.github.com/v3/activity/events/types/#webhook-event-name-13"
[ERROR] /home/r/repo/src/main/java/com/amihaiemil/charles/rest/NotificationsResource.java:131: warning - Tag @see:illegal character: "47" in "https://developer.github.com/v3/activity/events/types/#webhook-event-name-13"
[ERROR] /home/r/repo/src/main/java/com/amihaiemil/charles/rest/NotificationsResource.java:131: warning - Tag @see:illegal character: "47" in "https://developer.github.com/v3/activity/events/types/#webhook-event-name-13"
[ERROR] /home/r/repo/src/main/java/com/amihaiemil/charles/rest/NotificationsResource.java:131: warning - Tag @see:illegal character: "47" in "https://developer.github.com/v3/activity/events/types/#webhook-event-name-13"
[ERROR] /home/r/repo/src/main/java/com/amihaiemil/charles/rest/NotificationsResource.java:131: warning - Tag @see:illegal character: "45" in "https://developer.github.com/v3/activity/events/types/#webhook-event-name-13"
[ERROR] /home/r/repo/src/main/java/com/amihaiemil/charles/rest/NotificationsResource.java:131: warning - Tag @see:illegal character: "45" in "https://developer.github.com/v3/activity/events/types/#webhook-event-name-13"
[ERROR] /home/r/repo/src/main/java/com/amihaiemil/charles/rest/NotificationsResource.java:131: warning - Tag @see:illegal character: "45" in "https://developer.github.com/v3/activity/events/types/#webhook-event-name-13"
[ERROR] /home/r/repo/src/main/java/com/amihaiemil/charles/rest/RestApplication.java:36: error: unknown tag: todo
[ERROR] * @todo #162:1h/DEV Checkstyle validation was added but currently the
[ERROR] ^
[ERROR] /home/r/repo/src/main/java/com/amihaiemil/charles/rest/model/SearchResultsPage.java:100: error: @param name not found
[ERROR] * @param previousPage String.
[ERROR] ^
[ERROR] /home/r/repo/src/main/java/com/amihaiemil/charles/rest/model/SearchResultsPage.java:103: warning: no @param for prevPage
[ERROR] SearchResultsPage withPrevPage(final String prevPage);
[ERROR] ^
[ERROR] /home/r/repo/src/main/java/com/amihaiemil/charles/rest/model/ElasticSearchResults.java:54: error: @param name not found
[ERROR] * @param hits Results in JSON.
[ERROR] ^
[ERROR] /home/r/repo/src/main/java/com/amihaiemil/charles/rest/model/ElasticSearchResults.java:56: warning: no @param for results
[ERROR] public ElasticSearchResults(final JsonObject results) {
[ERROR] ^
[ERROR] /home/r/repo/src/main/java/com/amihaiemil/charles/rest/model/ElasticSearchResults.java:65: error: @param name not found
[ERROR] * @param preciousPage Link to the previous page.
[ERROR] ^
[ERROR] /home/r/repo/src/main/java/com/amihaiemil/charles/rest/model/ElasticSearchResults.java:68: warning: no @param for previousPage
[ERROR] public ElasticSearchResults(
[ERROR] ^
[ERROR] 
[ERROR] Command line was: /usr/lib/jvm/java-8-oracle/jre/../bin/javadoc @options @packages
[ERROR] 
[ERROR] Refer to the generated Javadoc files in '/home/r/repo/target/apidocs' dir.
[ERROR] -> [Help 1]
[ERROR] 
[ERROR] To see the full stack trace of the errors, re-run Maven with the -e switch.
[ERROR] Re-run Maven using the -X switch to enable full debug logging.
[ERROR] 
[ERROR] For more information about the errors and possible solutions, please read the following articles:
[ERROR] [Help 1] http://cwiki.apache.org/confluence/display/MAVEN/MojoExecutionException
container b326ba3ba18595b474e8a24603f987924e2691d0dfdc1153dc7fa4554f0aa334 is dead
Wed Oct 10 20:48:02 CEST 2018

[amihaiemil]

Let's fix these javadocs...

[amihaiemil]

@rultor try to release again, tag is 1.2.0

[rultor]

@rultor try to release again, tag is 1.2.0

@amihaiemil OK, I will release it now. Please check the progress here

[rultor]

@rultor try to release again, tag is 1.2.0

@amihaiemil Done! FYI, the full log is here (took me 5min)