Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Setting bad attributes #12

Closed
garthk opened this issue May 17, 2019 · 1 comment
Closed

Setting bad attributes #12

garthk opened this issue May 17, 2019 · 1 comment

Comments

@garthk
Copy link
Collaborator

garthk commented May 17, 2019

Rhyming with opencensus-beam/opencensus_datadog#8 but on the input side, I'm shoving some attributes into spans that don't comply with the specification.
garthk pushed a commit that referenced this issue May 17, 2019
Send sane span attributes (#12).
56c8300 
As we discovered during opencensus-beam/opencensus_datadog#8, OpenCensus
span attribute values [MUST] be one of:

* an integer
* a number
* a string
* a boolean

`:oc_trace.start_span/3` won't crash if we give it an attribute value of
`%Absinthe.Type.List{of_type: :string}`, but anything upstream encoding
to JSON or OpenCensus protobuf certainly will.

I've also renamed the attribute keys (also strings!) to match the period
delimited style used by `Opencensus.Plug.Trace`.

[MUST]: https://tools.ietf.org/html/rfc2119#section-1
@garthk
Copy link
Collaborator Author

garthk commented May 17, 2019

Fixed in 0.2.

@garthk garthk closed this as completed May 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@garthk