Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix wf config values not showing for scheduled events #978

Merged
merged 2 commits into from
Nov 19, 2024
Merged

Fix wf config values not showing for scheduled events #978

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
058ff5e
Fix wf config values not showing for scheduled events
Arnei Nov 6, 2024
d7fd7be
Stringify workflow configuration values
Arnei Nov 11, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions src/components/events/partials/ModalTabsAndPages/EventDetailsWorkflowTab.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -113,8 +113,6 @@ const EventDetailsWorkflowTab = ({
const setInitialValues = () => {
let initialConfig = undefined;

// TODO: Scheduled events are missing configuration for their workflow
// Figure out why the config is missing
if (baseWorkflow.configuration) {
initialConfig = parseBooleanInObject(baseWorkflow.configuration);
}
Expand Down
5 changes: 3 additions & 2 deletions src/slices/eventDetailsSlice.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1314,7 +1314,7 @@ export const fetchWorkflows = createAppAsyncThunk('eventDetails/fetchWorkflows',
workflow: {
workflowId: workflowsData.workflowId,
description: undefined,
configuration: undefined
configuration: workflowsData.configuration,
},
scheduling: true,
entries: [],
Expand Down Expand Up @@ -1830,7 +1830,8 @@ export const saveWorkflowConfig = createAppAsyncThunk('eventDetails/saveWorkflow

let header = getHttpHeaders();
let data = new URLSearchParams();
data.append("configuration", JSON.stringify(jsonData));
// Scheduler service in Opencast expects values to be strings, so we convert them here
data.append("configuration", JSON.stringify(jsonData, (k, v) => v && typeof v === 'object' ? v : '' + v));

axios
.put(`/admin-ng/event/${eventId}/workflows`, data, header)
Expand Down
Loading