Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix even more ts-expect-errors #885

Merged
merged 2 commits into from
Sep 5, 2024

Conversation

Arnei
Copy link
Member

@Arnei Arnei commented Aug 16, 2024

This fixes a majority of the remaining @ts-expect-error annotations by adding typing. As usual, this should not result in any functional changes, except maybe avoiding ui crashes in some edge cases and the like.

@Arnei Arnei added the type:typing Add typing label Aug 16, 2024
Copy link
Contributor

Use docker or podman to test this pull request locally.

Run test server using develop.opencast.org as backend:

podman run --rm -it -p 127.0.0.1:3000:3000 ghcr.io/opencast/opencast-admin-interface:pr-885

Specify a different backend like stable.opencast.org:

podman run --rm -it -p 127.0.0.1:3000:3000 -e PROXY_TARGET=https://stable.opencast.org ghcr.io/opencast/opencast-admin-interface:pr-885

It may take a few seconds for the interface to spin up.
It will then be available at http://127.0.0.1:3000.
For more options you can pass on to the proxy, take a look at the README.md.

Copy link
Contributor

github-actions bot commented Aug 16, 2024

This pull request is deployed at test.admin-interface.opencast.org/885/2024-09-05_07-24-26/ .
It might take a few minutes for it to become available.

@Arnei Arnei force-pushed the typing-many-ts-expect-errors branch from 0063407 to 9085944 Compare August 16, 2024 13:33
@Arnei Arnei force-pushed the typing-many-ts-expect-errors branch 2 times, most recently from 55a3615 to a2cbc00 Compare September 3, 2024 15:54
This fixes a majority of the remaining
`@ts-expect-error` annotaitons  by adding typing.
@Arnei Arnei force-pushed the typing-many-ts-expect-errors branch from a2cbc00 to 356a727 Compare September 5, 2024 07:23
@Arnei Arnei merged commit f056769 into opencast:main Sep 5, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:typing Add typing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant