Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix some CI linting errors #880

Merged
merged 1 commit into from
Aug 13, 2024
Merged

Conversation

owi92
Copy link
Contributor

@owi92 owi92 commented Aug 13, 2024

These came from an older PR that was made before there was linting in CI.

Copy link
Contributor

Use docker or podman to test this pull request locally.

Run test server using develop.opencast.org as backend:

podman run --rm -it -p 127.0.0.1:3000:3000 ghcr.io/opencast/opencast-admin-interface:pr-880

Specify a different backend like stable.opencast.org:

podman run --rm -it -p 127.0.0.1:3000:3000 -e PROXY_TARGET=https://stable.opencast.org ghcr.io/opencast/opencast-admin-interface:pr-880

It may take a few seconds for the interface to spin up.
It will then be available at http://127.0.0.1:3000.
For more options you can pass on to the proxy, take a look at the README.md.

@owi92 owi92 added the type:code-enhancement Internal improvements to the codebase label Aug 13, 2024
@owi92 owi92 force-pushed the fix-linting-errors branch from 625051d to f83b1e8 Compare August 13, 2024 15:50
These came from an older PR that was made before there was
linting in CI.
@owi92 owi92 force-pushed the fix-linting-errors branch from f83b1e8 to 271909d Compare August 13, 2024 16:02
Copy link
Contributor

This pull request is deployed at test.admin-interface.opencast.org/880/2024-08-13_16-02-29/ .
It might take a few minutes for it to become available.

@lkiesow lkiesow self-assigned this Aug 13, 2024
@lkiesow lkiesow merged commit 01512da into opencast:main Aug 13, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:code-enhancement Internal improvements to the codebase
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants