Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add more typing to resourceUtils #824

Merged
merged 3 commits into from
Aug 9, 2024
Merged

Conversation

Arnei
Copy link
Member

@Arnei Arnei commented Jul 9, 2024

Adds typescript to some methods in resourceUtils.ts that were still missing typing.
Also adds typing to event and series slices because they are related anyway.

Adds typescript to some methods in resourceUtils.ts
that were still missing typing.
Also adds typing to event and series slices because
they are related anyway.
@Arnei Arnei added the type:typing Add typing label Jul 9, 2024
Copy link
Contributor

github-actions bot commented Jul 9, 2024

Use docker or podman to test this pull request locally.

Run test server using develop.opencast.org as backend:

podman run --rm -it -p 127.0.0.1:3000:3000 ghcr.io/opencast/opencast-admin-interface:pr-824

Specify a different backend like stable.opencast.org:

podman run --rm -it -p 127.0.0.1:3000:3000 -e PROXY_TARGET=https://stable.opencast.org ghcr.io/opencast/opencast-admin-interface:pr-824

It may take a few seconds for the interface to spin up.
It will then be available at http://127.0.0.1:3000.
For more options you can pass on to the proxy, take a look at the README.md.

Copy link
Contributor

github-actions bot commented Jul 9, 2024

This pull request is deployed at test.admin-interface.opencast.org/824/2024-07-30_13-10-39/ .
It might take a few minutes for it to become available.

Copy link
Contributor

This pull request has conflicts ☹
Please resolve those so we can review the pull request.
Thanks.

@Arnei Arnei merged commit 93c4f6d into opencast:main Aug 9, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:typing Add typing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant