Fix up registration modal #816
Conversation
... instead of throwing a form right in their face.
Headers in the Adopte Registration had their top and bottom cut off.
Now that we show the information first again, it makes sense to go back to the information from the form.
In order to avoid words sticking together.
Adds back the summary page to the adopter registration which will show you exactly what data is being sent.
Make the thank you sentence at the end of the adopter registration a little more readable.
|
Use Run test server using develop.opencast.org as backend: Specify a different backend like stable.opencast.org: It may take a few seconds for the interface to spin up. |
|
This pull request is deployed at test.admin-interface.opencast.org/816/2024-07-24_14-56-51/ . |
|
Not sure if it's part of what you intended to fix with this pull request, but I noticed that one major issue is that the statistical information are not displayed at all:
This is how this looked in the old interface:
|
|
Thanks for the info, did not notice statistical information is displayed here. Will look into it. |
If the user agrees to sending usage statistics, show them what statistics they are sending.
|
While there is now a section “statistical information”, that section is just empty. That doesn't seem right? |
|
The reason Lars isn't seeing the statistical data is because he told Opencast not to send it. If you turn it on you see the data as expected. The bug here is that the whole UI component (Statistical Information, the textarea) should disappear if stats aren't being generated. Probably. It's still going to send the empty json object, but it won't contain data. Edit: The previous behaviour was to replace those UI components with a simple
|
…rface into main Pull request opencast#816 Fix up registration modal
Instead of showing the user an empty json, properly tell them that no statistics data will be shared with their adopter registration if they don't want to.
@gregorydlogan, that's an incorrect assumption. I've selected to send user statistics, but this doesn't work unless you selected it in a previous registration attempt. I've filed the issue as #858. I've also added a video demoing the problem. |
This contains various changes to the adopter registration modal that should bring it in line with how it used to work and just generally make it look a bit better. For a list of changes see the commit messages.