Fix required metadata not being required #800
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the backend, metadata catalogs can be configured as needed. One thing that can be configured for each metadata field is if is considered required. A user should not be able to leave a required field empty (or set it to
empty). Our validation was ignoring said configuration, merely enforcing the title field.
This fixes the issue by dynamically creating a validation schema based on configuration for the existing metadata fields. Although it really feels like Yup does not want me to do this.
Fixes #317.
Includes #798.