Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add typing to ModalNavigation #786

Merged
merged 1 commit into from
Jul 5, 2024
Merged

Conversation

Arnei
Copy link
Member

@Arnei Arnei commented Jul 2, 2024

Adds typescript to the ModalNavigation component.

@Arnei Arnei added the type:typing Add typing label Jul 2, 2024
Copy link
Contributor

github-actions bot commented Jul 2, 2024

Use docker or podman to test this pull request locally.

Run test server using develop.opencast.org as backend:

podman run --rm -it -p 127.0.0.1:3000:3000 ghcr.io/opencast/opencast-admin-interface:pr-786

Specify a different backend like stable.opencast.org:

podman run --rm -it -p 127.0.0.1:3000:3000 -e PROXY_TARGET=https://stable.opencast.org ghcr.io/opencast/opencast-admin-interface:pr-786

It may take a few seconds for the interface to spin up.
It will then be available at http://127.0.0.1:3000.
For more options you can pass on to the proxy, take a look at the README.md.

Adds typescript to the ModalNavigation component.
@Arnei Arnei force-pushed the typing-modal-navigation branch from 2368e8d to 5563c5b Compare July 2, 2024 15:24
Copy link
Contributor

github-actions bot commented Jul 2, 2024

This pull request is deployed at test.admin-interface.opencast.org/786/2024-07-02_15-24-55/ .
It might take a few minutes for it to become available.

@Arnei Arnei merged commit e96bc4e into opencast:main Jul 5, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:typing Add typing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant