Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Unsaved changes" popup showing up but changes are saved #757

Merged
merged 2 commits into from
Jul 2, 2024

Conversation

Arnei
Copy link
Member

@Arnei Arnei commented Jul 1, 2024

Fix an issue where a browser popup informing the user about unsaved changes would show up when trying to close the series details modal after editing acls, no matter if they actually saved their changes or not.

Fixes #382 (The missing translation string was already fixed elsewhere).

Fix an issue where a browser popup informing
the user about unsaved changes would show up
when trying to close the series details modal after
editing acls, no matter if they actually saved their
changes or not.
@Arnei Arnei added the type:bug Something isn't working label Jul 1, 2024
Copy link
Contributor

github-actions bot commented Jul 1, 2024

This pull request is deployed at test.admin-interface.opencast.org/757/2024-07-01_08-27-08/ .
It might take a few minutes for it to become available.

Copy link
Contributor

github-actions bot commented Jul 1, 2024

Use docker or podman to test this pull request locally.

Run test server using develop.opencast.org as backend:

podman run --rm -it -p 127.0.0.1:3000:3000 ghcr.io/opencast/opencast-admin-interface:pr-757

Specify a different backend like stable.opencast.org:

podman run --rm -it -p 127.0.0.1:3000:3000 -e PROXY_TARGET=https://stable.opencast.org ghcr.io/opencast/opencast-admin-interface:pr-757

It may take a few seconds for the interface to spin up.
It will then be available at http://127.0.0.1:3000.
For more options you can pass on to the proxy, take a look at the README.md.

Copy link
Contributor

github-actions bot commented Jul 1, 2024

This pull request has conflicts ☹
Please resolve those so we can review the pull request.
Thanks.

@lkiesow lkiesow self-assigned this Jul 1, 2024
@lkiesow lkiesow merged commit 6773d68 into opencast:main Jul 2, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Wrong UNSAVED_CHANGES warning
2 participants