Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deselect all rows after start task #754

Merged
merged 2 commits into from
Jul 2, 2024

Conversation

Arnei
Copy link
Member

@Arnei Arnei commented Jun 28, 2024

After starting a task on the selected events, this causes all events to become unselected.

Fixes #403.

After starting a task on the selected events,
this causes all events to become unselected.
@Arnei Arnei added the type:usability Improves the UX label Jun 28, 2024
Copy link
Contributor

Use docker or podman to test this pull request locally.

Run test server using develop.opencast.org as backend:

podman run --rm -it -p 127.0.0.1:3000:3000 ghcr.io/opencast/opencast-admin-interface:pr-754

Specify a different backend like stable.opencast.org:

podman run --rm -it -p 127.0.0.1:3000:3000 -e PROXY_TARGET=https://stable.opencast.org ghcr.io/opencast/opencast-admin-interface:pr-754

It may take a few seconds for the interface to spin up.
It will then be available at http://127.0.0.1:3000.
For more options you can pass on to the proxy, take a look at the README.md.

Copy link
Contributor

github-actions bot commented Jun 28, 2024

This pull request is deployed at test.admin-interface.opencast.org/754/2024-07-01_06-18-32/ .
It might take a few minutes for it to become available.

Copy link
Member

@lkiesow lkiesow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good apart from the minor indentation issue.

Comment on lines 22 to 23
postTasks,
changeAllSelected
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I know it's annoying, but… inconsistent indentation.

@lkiesow lkiesow self-assigned this Jun 28, 2024
@lkiesow lkiesow merged commit 23fc014 into opencast:main Jul 2, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:usability Improves the UX
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Videos still selected after “Start Task”
2 participants