Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve embed codes #753

Merged
merged 1 commit into from
Jul 23, 2024
Merged

Improve embed codes #753

merged 1 commit into from
Jul 23, 2024

Conversation

lkiesow
Copy link
Member

@lkiesow lkiesow commented Jun 27, 2024

This patch improves the embed code which was somewhat wird. For example, style="border:0px #FFFFFF none;" did not make much sense since the syntax for border is width | style | color¹.

[1]

This patch improves the embed code which was somewhat wird. For example,
`style="border:0px #FFFFFF none;"` did not make much sense since the
syntax for `border` is `width | style | color`¹.

[[1]](https://developer.mozilla.org/en-US/docs/Web/CSS/border)
@lkiesow lkiesow added the type:bug Something isn't working label Jun 27, 2024
Copy link
Contributor

This pull request is deployed at test.admin-interface.opencast.org/753/2024-06-27_19-57-49/ .
It might take a few minutes for it to become available.

Copy link
Contributor

Use docker or podman to test this pull request locally.

Run test server using develop.opencast.org as backend:

podman run --rm -it -p 127.0.0.1:3000:3000 ghcr.io/opencast/opencast-admin-interface:pr-753

Specify a different backend like stable.opencast.org:

podman run --rm -it -p 127.0.0.1:3000:3000 -e PROXY_TARGET=https://stable.opencast.org ghcr.io/opencast/opencast-admin-interface:pr-753

It may take a few seconds for the interface to spin up.
It will then be available at http://127.0.0.1:3000.
For more options you can pass on to the proxy, take a look at the README.md.

@gregorydlogan gregorydlogan self-assigned this Jul 23, 2024
@gregorydlogan gregorydlogan merged commit 1e3906a into opencast:main Jul 23, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants