Asset-Upload fixed #750
Asset-Upload fixed #750
Conversation
This patch fixes the asset upload.
|
Use Run test server using develop.opencast.org as backend: Specify a different backend like stable.opencast.org: It may take a few seconds for the interface to spin up. |
|
This pull request is deployed at test.admin-interface.opencast.org/750/2024-07-08_14-12-16/ . |
There was a problem hiding this comment.
Works and makes sense to me.
Ideally we would not have to make assumptions about magic variables in workflows and have the backend sort it out somehow, but arguably restoring the upload to working order is more important and the assumptions we have to make are not too annoying.
Minor nitpicks below:
src/slices/eventDetailsSlice.ts
Outdated
|
|
||
| let processing: { | ||
| workflow: string | undefined, | ||
| configuration: typeof uploadAssetWorkflowConfiguration, |
There was a problem hiding this comment.
Should be using tabs instead of spaces for indentation.
src/slices/eventDetailsSlice.ts
Outdated
| } | ||
| }); | ||
|
|
||
| let uploadAssetWorkflowConfiguration: { |
There was a problem hiding this comment.
Minor stylistic nitpick: It is preferred to use const instead of let whenever possible.
There was a problem hiding this comment.
Thank you for the info. I've updated the PR.
src/slices/eventDetailsSlice.ts
Outdated
| options: [], | ||
| }; | ||
|
|
||
| let assetFlavors: string = ""; |
There was a problem hiding this comment.
It is not necessary to type everything explicitly. For example, in this case typescripts type inference would have no problem inferring that this should be a string.
Co-authored-by: Arne Wilken <[email protected]>
|
Thank you @Arnei. I've updated the PR with your suggestions. Please continue review. |
This patch fixes the asset upload.