Prevent sort icon from breaking table headers #746
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We're currently applying arbitrary word-wrapping to our table cells to keep very long strings from overflowing. This can cause some columns to get very little width in certain cases. This removes word-wrapping from table headers to rectify that issue. Table header contents are controlled by us and should not be terribly long either way, so in my opinion this is fine.
Applies flexbox to table headers to keep table header contents from line breaking. This is supposed to help with cases where the title would be on one line and the sort icon on the next, wasting space and looking quite bad.
|
Use Run test server using develop.opencast.org as backend: Specify a different backend like stable.opencast.org: It may take a few seconds for the interface to spin up. |
|
This pull request is deployed at test.admin-interface.opencast.org/746/2024-06-26_14-04-10/ . |
lkiesow
approved these changes
Jul 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Applies flexbox to table headers to keep table header contents from line breaking. This is supposed to help with cases where the title would be on one line and the sort icon on the next, wasting space and looking quite bad.
Includes #744, so that should be merged first.
Before:
After:
