Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hide tooltip on hover #740

Merged
merged 2 commits into from
Jun 25, 2024
Merged

Hide tooltip on hover #740

merged 2 commits into from
Jun 25, 2024

Conversation

dennis531
Copy link
Contributor

Close #722

Copy link
Contributor

Use docker or podman to test this pull request locally.

Run test server using develop.opencast.org as backend:

podman run --rm -it -p 127.0.0.1:3000:3000 ghcr.io/opencast/opencast-admin-interface:pr-740

Specify a different backend like stable.opencast.org:

podman run --rm -it -p 127.0.0.1:3000:3000 -e PROXY_TARGET=https://stable.opencast.org ghcr.io/opencast/opencast-admin-interface:pr-740

It may take a few seconds for the interface to spin up.
It will then be available at http://127.0.0.1:3000.
For more options you can pass on to the proxy, take a look at the README.md.

Copy link
Contributor

github-actions bot commented Jun 25, 2024

This pull request is deployed at test.admin-interface.opencast.org/740/2024-06-25_15-51-24/ .
It might take a few minutes for it to become available.

@Arnei
Copy link
Member

Arnei commented Jun 25, 2024

Might not be the best way to go about this. In the Opencast Editor, tooltips explicitly do not disappear even if you click on them, allowing you to mark the contents. Iirc this was done for usability and accessibility reasons which should also be important to us here in the admin ui.

Copy link
Member

@lkiesow lkiesow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

-1 to this solution. Having non-interactive tooltips is bad for accessibility. In particular, trying to use this in combination with screen magnifications is bad. A simple alternative solution for #722 would be placement='right'.

@lkiesow lkiesow added the type:visual-clarity Improves UI readability label Jun 25, 2024
@dennis531
Copy link
Contributor Author

dennis531 commented Jun 25, 2024

Thanks for the suggestions. The main navigation tooltips are placed on the right side. I hope this improves the usability.

@dennis531 dennis531 requested a review from lkiesow June 25, 2024 15:54
@lkiesow
Copy link
Member

lkiesow commented Jun 25, 2024

Looks good

@lkiesow lkiesow merged commit e77eb04 into opencast:main Jun 25, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:visual-clarity Improves UI readability
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Tooltip for main menu items covers other main menu item
3 participants