Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hide type and flavor of add asset items #737

Merged
merged 2 commits into from
Jun 26, 2024

Conversation

wsmirnow
Copy link
Contributor

@wsmirnow wsmirnow commented Jun 25, 2024

To be consistent, the Add-Asset dialog shouldn't show the type and flavor of the items, same as Add-event dialog.

Before:
image

After:
image

The new event summary page should also hide the asset type and flavor.

Before:
new-event-summary-before

After:
image

To be consistent, the Add-Asset dialog shouldn't show the type and flavor of the items, same as Add-event dialog.
Copy link
Contributor

Use docker or podman to test this pull request locally.

Run test server using develop.opencast.org as backend:

podman run --rm -it -p 127.0.0.1:3000:3000 ghcr.io/opencast/opencast-admin-interface:pr-737

Specify a different backend like stable.opencast.org:

podman run --rm -it -p 127.0.0.1:3000:3000 -e PROXY_TARGET=https://stable.opencast.org ghcr.io/opencast/opencast-admin-interface:pr-737

It may take a few seconds for the interface to spin up.
It will then be available at http://127.0.0.1:3000.
For more options you can pass on to the proxy, take a look at the README.md.

Copy link
Contributor

github-actions bot commented Jun 25, 2024

This pull request is deployed at test.admin-interface.opencast.org/737/2024-06-25_09-53-41/ .
It might take a few minutes for it to become available.

@wsmirnow wsmirnow added type:visual-clarity Improves UI readability type:usability Improves the UX labels Jun 25, 2024
Copy link
Member

@Arnei Arnei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense to me!

@Arnei Arnei merged commit 97a61d6 into opencast:main Jun 26, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:usability Improves the UX type:visual-clarity Improves UI readability
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants