Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Einbettungscode Dialog a11y issues #625 #736

Merged
merged 2 commits into from
Jun 26, 2024
Merged

Einbettungscode Dialog a11y issues #625 #736

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5f9898a
add live area and turn divs into buttons
rlucke Jun 24, 2024
732e633
Merge branch 'opencast:main' into issue-625
rlucke Jun 26, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
38 changes: 18 additions & 20 deletions src/components/events/partials/modals/EmbeddingCodeModal.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -101,41 +101,41 @@ const EmbeddingCodeModal = ({

{/* embed size buttons */}
<div className="embedded-code-boxes">
<div
<button
id="620x349"
className="embedSizeButton size_620x349"
className="embedSizeButton size_620x349 button-like-anchor"
onClick={(e) => updateTextArea(e)}
>
<span className="span-embedded-code">620x349</span>
</div>
<div
</button>
<button
id="540x304"
className="embedSizeButton size_540x304"
className="embedSizeButton size_540x304 button-like-anchor"
onClick={(e) => updateTextArea(e)}
>
<span className="span-embedded-code">540x304</span>
</div>
<div
</button>
<button
id="460x259"
className="embedSizeButton size_460x259"
className="embedSizeButton size_460x259 button-like-anchor"
onClick={(e) => updateTextArea(e)}
>
<span className="span-embedded-code">460x259</span>
</div>
<div
</button>
<button
id="380x214"
className="embedSizeButton size_380x214"
className="embedSizeButton size_380x214 button-like-anchor"
onClick={(e) => updateTextArea(e)}
>
<span className="span-embedded-code">380x214</span>
</div>
<div
</button>
<button
id="300x169"
className="embedSizeButton size_300x169"
className="embedSizeButton size_300x169 button-like-anchor"
onClick={(e) => updateTextArea(e)}
>
<span className="span-embedded-code">300x169</span>
</div>
</button>
</div>

<span id="id_video" className="embedded-code-no-visible">
Expand All @@ -147,17 +147,15 @@ const EmbeddingCodeModal = ({
<textarea
id="social_embed-textarea"
className="social_embed-textarea embedded-code-textarea"
// @ts-expect-error TS(2322): Type 'string' is not assignable to type 'number'.
rows="4"
rows={4}
value={textAreaContent}
// @ts-expect-error TS(2322): Type 'string' is not assignable to type 'number'.
cols="1"
cols={1}
/>
</div>

{/* copy confirmation */}
{showCopySuccess && (
<div className="copyConfirm">
<div className="copyConfirm" role="alert">
<span id="copy_confirm_pre">
{t("CONFIRMATIONS.EMBEDDING_CODE",{size: currentSize})}
</span>
Expand Down
Loading