-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Custom roles in ACL policy #729
Conversation
This pull request is deployed at test.admin-interface.opencast.org/729/2024-07-11_12-28-21/ . |
Use Run test server using develop.opencast.org as backend:
Specify a different backend like stable.opencast.org:
It may take a few seconds for the interface to spin up. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code works and looks reasonable.
As for the alternative you suggested:
Therefore I'm slightly in favor of the no-button alternative, but it's not hard enough of an opinion that I would block this PR. |
I prefer to have only one button, as the new create dropdown can also be used to select existing ACLs. In my opinion, this separation would rather confuse users and lead to lower usability. We could also use the create dropdown for editing roles to avoid the workaround of removing policies. |
This pull request has conflicts ☹ |
Changes: - Dropdowns for new policies are always creatable - Allow creating new roles in existing policies
Done as described. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works and looks good to me. Really like this over having an extra button. One minor nitpick below.
Changes
Alternative
We could show only one button "new policy" and enable the creation in the dropdown
Screenshot
Close #658