Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Default typing for createAsyncThunk #728

Merged
merged 1 commit into from
Jul 1, 2024

Conversation

Arnei
Copy link
Member

@Arnei Arnei commented Jun 21, 2024

Wraps createAsyncThunk in createAsyncThunk.withTypes, allowing us to provide default typing and remove certain type
assertions.

Wraps `createAsyncThunk` in `createAsyncThunk.withTypes`, allowing us to
provide default typing and remove certain type
assertions.
@Arnei Arnei added type:typing Add typing type:code-enhancement Internal improvements to the codebase labels Jun 21, 2024
Copy link
Contributor

Use docker or podman to test this pull request locally.

Run test server using develop.opencast.org as backend:

podman run --rm -it -p 127.0.0.1:3000:3000 ghcr.io/opencast/opencast-admin-interface:pr-728

Specify a different backend like stable.opencast.org:

podman run --rm -it -p 127.0.0.1:3000:3000 -e PROXY_TARGET=https://stable.opencast.org ghcr.io/opencast/opencast-admin-interface:pr-728

It may take a few seconds for the interface to spin up.
It will then be available at http://127.0.0.1:3000.
For more options you can pass on to the proxy, take a look at the README.md.

Copy link
Contributor

This pull request is deployed at test.admin-interface.opencast.org/728/2024-06-21_10-15-56/ .
It might take a few minutes for it to become available.

@Arnei Arnei merged commit ca662a8 into opencast:main Jul 1, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:code-enhancement Internal improvements to the codebase type:typing Add typing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant