Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix a11y issues in header nav #718

Merged
merged 3 commits into from
Jun 26, 2024
Merged

fix a11y issues in header nav #718

merged 3 commits into from
Jun 26, 2024

Conversation

rlucke
Copy link
Contributor

@rlucke rlucke commented Jun 20, 2024

use button tag instead of div
reorder tooltip
add some css changes to keep layout

fixes #605
fixes #601
fixes #603

@rlucke rlucke added the type:accessibility This would help impaired users label Jun 20, 2024
Copy link
Contributor

Hi @rlucke
Thank you for contributing to the Opencast Editor.
We noticed that you have not yet filed an Individual Contributor License Agreement. Doing that (once) helps us to ensure that Opencast stays free for all. If you make your contribution on behalf of an institution, you might also want to file a Corporate Contributor License Agreement (giving you as individual contributor a bit more security as well). It can take a while for this bot to find out about new filings, so if you just filed one or both of the above do not worry about this message!
Please let us know if you have any questions regarding the CLA.

Copy link
Contributor

github-actions bot commented Jun 20, 2024

This pull request is deployed at test.admin-interface.opencast.org/718/2024-06-20_12-37-50/ .
It might take a few minutes for it to become available.

Copy link
Contributor

Use docker or podman to test this pull request locally.

Run test server using develop.opencast.org as backend:

podman run --rm -it -p 127.0.0.1:3000:3000 ghcr.io/opencast/opencast-admin-interface:pr-718

Specify a different backend like stable.opencast.org:

podman run --rm -it -p 127.0.0.1:3000:3000 -e PROXY_TARGET=https://stable.opencast.org ghcr.io/opencast/opencast-admin-interface:pr-718

It may take a few seconds for the interface to spin up.
It will then be available at http://127.0.0.1:3000.
For more options you can pass on to the proxy, take a look at the README.md.

Copy link
Member

@Arnei Arnei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can navigate to all buttons in the header via tabbing now, and layout is kept. Nice.

@Arnei
Copy link
Member

Arnei commented Jun 20, 2024

As a note, adding translations in PR has no effect, as crowdin can and will override any changes not made directly to the "source" file (lang-en_US.json). If you would like to help with translations, please request access to our crowdin project at crowdin.com/project/opencast-admin-interface.

@Arnei
Copy link
Member

Arnei commented Jun 20, 2024

Also this is probably obvious, but I do not understand how this addresses #603. Could you explain?

@rlucke
Copy link
Contributor Author

rlucke commented Jun 26, 2024

Also this is probably obvious, but I do not understand how this addresses #603. Could you explain?

The correct position of the ToolTip in the template enables the screenreader to say more than just "link".

@Arnei Arnei merged commit e367306 into opencast:main Jun 26, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:accessibility This would help impaired users
Projects
None yet
2 participants