-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix a11y issues in header nav #718
Conversation
Hi @rlucke |
This pull request is deployed at test.admin-interface.opencast.org/718/2024-06-20_12-37-50/ . |
Use Run test server using develop.opencast.org as backend:
Specify a different backend like stable.opencast.org:
It may take a few seconds for the interface to spin up. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can navigate to all buttons in the header via tabbing now, and layout is kept. Nice.
As a note, adding translations in PR has no effect, as crowdin can and will override any changes not made directly to the "source" file (lang-en_US.json). If you would like to help with translations, please request access to our crowdin project at crowdin.com/project/opencast-admin-interface. |
Also this is probably obvious, but I do not understand how this addresses #603. Could you explain? |
The correct position of the ToolTip in the template enables the screenreader to say more than just "link". |
use button tag instead of div
reorder tooltip
add some css changes to keep layout
fixes #605
fixes #601
fixes #603