Fix type error for missing organization property #715
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If an organization property does not exist, the admin interface
completely breaks in some cases. This seems to happen on
admin-interface.opencast.org right now:
```
Uncaught TypeError: u.toLowerCase is not a function
qr Footer.tsx:25
React 8
D scheduler.production.min.js:13
$ scheduler.production.min.js:14
Footer.tsx:25:80
```
What's interesting is that this only seems to happen with the compiled
code. Starting the development server, calling `toLowerCase()` just
works.
In any case, this patch fixes the issue by providing the default value
first, so that `toLowerCase()` is always called on a string.
|
This pull request is deployed at test.admin-interface.opencast.org/715/2024-06-19_15-47-48/ . |
|
Use Run test server using develop.opencast.org as backend: Specify a different backend like stable.opencast.org: It may take a few seconds for the interface to spin up. |
Arnei
approved these changes
Jun 20, 2024
JulianKniephoff
previously requested changes
Jun 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If an organization property does not exist, the admin interface completely breaks in some cases. This seems to happen on admin-interface.opencast.org right now:
What's interesting is that this only seems to happen with the compiled code. Starting the development server, calling
toLowerCase()just works.In any case, this patch fixes the issue by providing the default value first, so that
toLowerCase()is always called on a string.