Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Center tooltips on main menu items #688

Merged
merged 1 commit into from
Jun 11, 2024
Merged

Conversation

lkiesow
Copy link
Member

@lkiesow lkiesow commented Jun 9, 2024

The tooltips on the main menu items start really far away from the icons. This patch makes them activate only on the icon.

The tooltips on the main menu items start really far away from the
icons. This patch makes them activate only on the icon.
@lkiesow lkiesow added the type:visual-clarity Improves UI readability label Jun 9, 2024
Copy link
Contributor

github-actions bot commented Jun 9, 2024

This pull request is deployed at test.admin-interface.opencast.org/688/2024-06-09_12-36-50/ .
It might take a few minutes for it to become available.

Copy link
Contributor

github-actions bot commented Jun 9, 2024

Use docker or podman to test this pull request locally.

Run test server using develop.opencast.org as backend:

podman run --rm -it -p 127.0.0.1:3000:3000 ghcr.io/opencast/opencast-admin-interface:pr-688

Specify a different backend like stable.opencast.org:

podman run --rm -it -p 127.0.0.1:3000:3000 -e PROXY_TARGET=https://stable.opencast.org ghcr.io/opencast/opencast-admin-interface:pr-688

It may take a few seconds for the interface to spin up.
It will then be available at http://127.0.0.1:3000.
For more options you can pass on to the proxy, take a look at the README.md.

@stefanosgeo stefanosgeo self-assigned this Jun 10, 2024
@stefanosgeo
Copy link
Contributor

It does what it should, but there are (?) issues. For example when using the dev tools for responsive design, the tooltips are still not aligned properly. Additionally, from the screenshot(text "Event" overlapping with status tabs, it appears there are other problems as well.

Screenshot from 2024-06-10 11-54-20

@lkiesow
Copy link
Member Author

lkiesow commented Jun 10, 2024

You are absolutely right. Can you file the responsive design problems as separate issues?
This pull request just aims to be a small improvement for the tooltips in the main menu.
Adressing the overlapping texts on small screens is likely a bit more work.

@stefanosgeo
Copy link
Contributor

You are absolutely right. Can you file the responsive design problems as separate issues? This pull request just aims to be a small improvement for the tooltips in the main menu. Adressing the overlapping texts on small screens is likely a bit more work.

I will. Then this PR addresses and fixes the described problem.

@lkiesow
Copy link
Member Author

lkiesow commented Jun 11, 2024

Thanks for reviewing this. Since it was reviewed and later discussed at the technical meeting, I'm merging this.

@lkiesow lkiesow merged commit 278c14f into opencast:main Jun 11, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:visual-clarity Improves UI readability
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants