Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add aria-label to the filter select element. #679

Merged
merged 1 commit into from
Jun 7, 2024

Conversation

luniki
Copy link
Contributor

@luniki luniki commented Jun 7, 2024

Fixes #596.

See:
image

@luniki luniki added the type:accessibility This would help impaired users label Jun 7, 2024
Copy link
Contributor

github-actions bot commented Jun 7, 2024

This pull request is deployed at test.admin-interface.opencast.org/679/2024-06-07_08-17-16/ .
It might take a few minutes for it to become available.

Copy link
Contributor

github-actions bot commented Jun 7, 2024

Use docker or podman to test this pull request locally.

Run test server using develop.opencast.org as backend:

podman run --rm -it -p 127.0.0.1:3000:3000 ghcr.io/opencast/opencast-admin-interface:pr-679

Specify a different backend like stable.opencast.org:

podman run --rm -it -p 127.0.0.1:3000:3000 -e PROXY_TARGET=https://stable.opencast.org ghcr.io/opencast/opencast-admin-interface:pr-679

It may take a few seconds for the interface to spin up.
It will then be available at http://127.0.0.1:3000.
For more options you can pass on to the proxy, take a look at the README.md.

@lkiesow lkiesow merged commit d5779a9 into opencast:main Jun 7, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:accessibility This would help impaired users
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Select element in filter component are not labelled
2 participants