Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Date Display in Add Event #673

Merged
merged 2 commits into from
Jun 11, 2024
Merged

Conversation

lkiesow
Copy link
Member

@lkiesow lkiesow commented Jun 6, 2024

This patch fixes a bunch of errors related to display of date and time in the add event wizard:

  • If you select a start date and time for an uploaded event, the summary would only show a date, not the time.
  • If you schedule an event, the summary would show a date-time string as start date which is off by one day for everyone operating in a UTC+x timezone.
  • If you schedule an event which ends on a day other than the startt date, the summary wouldn't reflect that.

All this should now be fixed.

This fixes #662

This patch fixes a bunch of errors related to display of date and time
in the add event wizard:

- If you select a start date and time for an uploaded event, the summary
  would only show a date, not the time.
- If you schedule an event, the summary would show a date-time string as
  start date which is off by one day for everyone operating in a UTC+x
  timezone.
- If you schedule an event which ends on a day other than the startt
  date, the summary wouldn't reflect that.

All this should now be fixed.
@lkiesow lkiesow added the type:bug Something isn't working label Jun 6, 2024
Copy link
Contributor

github-actions bot commented Jun 6, 2024

This pull request is deployed at test.admin-interface.opencast.org/673/2024-06-07_14-38-25/ .
It might take a few minutes for it to become available.

Copy link
Contributor

github-actions bot commented Jun 6, 2024

Use docker or podman to test this pull request locally.

Run test server using develop.opencast.org as backend:

podman run --rm -it -p 127.0.0.1:3000:3000 ghcr.io/opencast/opencast-admin-interface:pr-673

Specify a different backend like stable.opencast.org:

podman run --rm -it -p 127.0.0.1:3000:3000 -e PROXY_TARGET=https://stable.opencast.org ghcr.io/opencast/opencast-admin-interface:pr-673

It may take a few seconds for the interface to spin up.
It will then be available at http://127.0.0.1:3000.
For more options you can pass on to the proxy, take a look at the README.md.

Arnei
Arnei previously requested changes Jun 7, 2024
Copy link
Member

@Arnei Arnei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixes everything listed in the description, code looks reasonable. Got one suggestion down below.

src/utils/dateUtils.ts Outdated Show resolved Hide resolved
@lkiesow lkiesow requested a review from Arnei June 7, 2024 14:36
@lkiesow lkiesow dismissed Arnei’s stale review June 7, 2024 14:36

Code updated

Moment allows you to get a fate string based on local time which is
exactly what we need.
@lkiesow lkiesow force-pushed the fix-date-display branch from fafd097 to c273618 Compare June 7, 2024 14:38
@lkiesow lkiesow changed the title Fix Date Display in Add Eventt Fix Date Display in Add Event Jun 10, 2024
@Arnei Arnei merged commit 3dee3db into opencast:main Jun 11, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Start date is a date-time value, but summary in add event shows only the date
2 participants