Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix file upload labels #667

Merged
merged 3 commits into from
Jun 6, 2024
Merged

Fix file upload labels #667

merged 3 commits into from
Jun 6, 2024

Conversation

lkiesow
Copy link
Member

@lkiesow lkiesow commented Jun 6, 2024

The file upload dialog in the add events dialog does not work well with
long filenames and even renders the filename twice. This patch fixes
that.

Screenshot from 2024-06-06 12-00-49

This patch is based on #666 which fixes the broken table in that dialog.

This fixes #661

lkiesow added 2 commits June 6, 2024 11:35
This patch fixes the table layout of the upload section in the add
event dialog which had overlapping elements.

Not the actions again have their own small column.
The file upload dialog in the add events dialog does not work well with
long filenames and even renders the filename twice. This patch fixes
that.
Copy link
Contributor

github-actions bot commented Jun 6, 2024

This pull request is deployed at test.admin-interface.opencast.org/667/2024-06-06_12-26-49/ .
It might take a few minutes for it to become available.

@lkiesow lkiesow added type:bug Something isn't working type:visual-clarity Improves UI readability labels Jun 6, 2024
Copy link
Contributor

github-actions bot commented Jun 6, 2024

Use docker or podman to test this pull request locally.

Run test server using develop.opencast.org as backend:

podman run --rm -it -p 127.0.0.1:3000:3000 ghcr.io/opencast/opencast-admin-interface:pr-667

Specify a different backend like stable.opencast.org:

podman run --rm -it -p 127.0.0.1:3000:3000 -e PROXY_TARGET=https://stable.opencast.org ghcr.io/opencast/opencast-admin-interface:pr-667

It may take a few seconds for the interface to spin up.
It will then be available at http://127.0.0.1:3000.
For more options you can pass on to the proxy, take a look at the README.md.

Arnei
Arnei previously requested changes Jun 6, 2024
src/styles/main.scss Outdated Show resolved Hide resolved
@lkiesow lkiesow dismissed Arnei’s stale review June 6, 2024 12:51

Updatted code

@Arnei Arnei merged commit 1d1154e into opencast:main Jun 6, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:bug Something isn't working type:visual-clarity Improves UI readability
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Long file names break the add event dialog
2 participants