Disable statistics tab by default #660
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request is deployed at test.admin-interface.opencast.org/660/2024-06-11_16-39-13/ . |
|
Use Run test server using develop.opencast.org as backend: Specify a different backend like stable.opencast.org: It may take a few seconds for the interface to spin up. |
lkiesow
added a commit
to lkiesow/opencast
that referenced
this pull request
Jun 5, 2024
This patch provides the configuration option for: opencast/opencast-admin-interface#660
7 tasks
lkiesow
changed the title
gregorydlogan
requested changes
Jun 11, 2024
gregorydlogan
added a commit
to gregorydlogan/opencast
that referenced
this pull request
Jun 11, 2024
7 tasks
By default the statistics view is broken and you need additional configuration. Therefor, it should be disabled by default in the admin interface. Unlike the old interface, this patch does not read the actual data from statistics providers, but uses a configuration option to determine if the statistics feature should be an option in the UI. This fixes opencast#357
lkiesow
added a commit
to opencast/opencast
that referenced
this pull request
Jun 11, 2024
This PR comments out a default that should have been commented out but was left uncommented accidentally. Also fixed a spelling mistake I missed with #5909 relating to opencast/opencast-admin-interface#660 TODO: There are a number of *other* defaults which are not commented out... ### Your pull request should… * [x] have a concise title * [ ] ~[close an accompanying issue](https://docs.opencast.org/develop/developer/#participate/development-process/#automatically-closing-issues-when-a-pr-is-merged) if one exists~ * [x] [be against the correct branch](https://docs.opencast.org/develop/developer/development-process#acceptance-criteria-for-patches-in-different-versions) * [ ] ~include migration scripts and documentation, if appropriate~ * [x] pass automated tests * [x] have a clean commit history * [x] [have proper commit messages (title and body) for all commits](https://medium.com/@steveamaza/e028865e5791)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By default the statistics view is broken and you need additional configuration. Therefor, it should be disabled by default in the admin interface.
Unlike the old interface, this patch does not read the actual data from statistics providers, but uses a configuration option to determine if the statistics feature should be an option in the UI.
The configuration and documentation is added in pull request opencast/opencast#5909
This fixes #357