Fix unnecessary green ticks in Metadata wizard

[ferishili]

This PR fixes #629,

The problem comes from comparing arrays like other types, which in this case of !== is always true.
The correct way of comparing array is to convert them into json string and then check if they are equal!

With this PR, you will see the green tick only after changing the value of the inputs, which is the intended behavior!

[github-actions]

This pull request is deployed at test.admin-interface.opencast.org/657/2024-06-05_16-07-26/ .
It might take a few minutes for it to become available.

[github-actions]

Use docker or podman to test this pull request locally.

Run test server using develop.opencast.org as backend:

podman run --rm -it -p 127.0.0.1:3000:3000 ghcr.io/opencast/opencast-admin-interface:pr-657

Specify a different backend like stable.opencast.org:

podman run --rm -it -p 127.0.0.1:3000:3000 -e PROXY_TARGET=https://stable.opencast.org ghcr.io/opencast/opencast-admin-interface:pr-657

It may take a few seconds for the interface to spin up.
It will then be available at http://127.0.0.1:3000.
For more options you can pass on to the proxy, take a look at the README.md.

[ziegenberg]

I can't currently reproduce this error on https://develop.opencast.org. So are we fixing a real issue here? I also asked the issue creator for more details: #629 (comment)

[geichelberger]

In the PR #398, the ticks were still working as expected and were broken in PR #399 as those got merged after the latest release develop is not broken. Maybe 399 introduced the changes or something that got merged in between those PRs.

[Arnei]

Regardless of how this came to be broken, this does fix the issue in a reasonable manner I think. So this gets an approval from me.

[lkiesow]

+1 for merging the pull request like this. It's definitely an improvement over having random green check marks.

That being said, I think we would get just rid of them. They existed before we had a save button to indicate that a modified field had been saved. Now, I think they are just confusing and not helpful at all.

[Arnei]

That being said, I think we would get just rid of them. They existed before we had a save button to indicate that a modified field had been saved. Now, I think they are just confusing and not helpful at all.

Disagree on that. I think they are useful as feedback that your input has been recognized. They could also indicate that your input was valid, but alas our validation is ... lacking right now.

[geichelberger]

Indicating which field changed is nice; the question is whether adding a green tick is the way to go.

[lkiesow]

Let's move this discussion to a separate issue.

Any objections to merging this @Arnei, @geichelberger, @ziegenberg?

[geichelberger]

+1 merging

[ziegenberg]

It's fine with me

[Arnei]

Fine by me!

[lkiesow]

Then let's merge this.