Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix filter functionality and performance #627

Merged
merged 3 commits into from
Jun 6, 2024
Merged

Conversation

ferishili
Copy link
Contributor

This PR fixes #211 and covers #577,

The filter functionality problem (on page > 1) has been solved by going to first page and load resources!

The performance issue has been solved by introducing debounce mechanism on loading resources.
This also covers Filter profiles!

Copy link
Contributor

github-actions bot commented Jun 5, 2024

This pull request is deployed at test.admin-interface.opencast.org/627/2024-06-05_12-57-07/ .
It might take a few minutes for it to become available.

Copy link
Contributor

github-actions bot commented Jun 5, 2024

Use docker or podman to test this pull request locally.

Run test server using develop.opencast.org as backend:

podman run --rm -it -p 127.0.0.1:3000:3000 ghcr.io/opencast/opencast-admin-interface:pr-627

Specify a different backend like stable.opencast.org:

podman run --rm -it -p 127.0.0.1:3000:3000 -e PROXY_TARGET=https://stable.opencast.org ghcr.io/opencast/opencast-admin-interface:pr-627

It may take a few seconds for the interface to spin up.
It will then be available at http://127.0.0.1:3000.
For more options you can pass on to the proxy, take a look at the README.md.

@ferishili ferishili added type:bug Something isn't working type:code-enhancement Internal improvements to the codebase type:visual-clarity Improves UI readability bugbash labels Jun 5, 2024
@kruemelm0nsta
Copy link

in general fixed - just looks a little bit wobbly

grafik

@ferishili
Copy link
Contributor Author

ferishili commented Jun 5, 2024

in general fixed - just looks a little bit wobbly

grafik

Right, but the problem with datepicker in the filter was not covered by the initial issue #211,
Therefore, datepicker misplacement needs to be fixed in a separate issue.

@ferishili
Copy link
Contributor Author

#528 here is the issue regarding datepicker UI

@snoesberger
Copy link
Contributor

Works mostly, but not if I'm using the start date as filter. If I go to page 3 and enter a start date filter, filtering is not working. In the browser console I do get the following error:

MUI X: A component is changing the uncontrolled value of a picker to be controlled.
Elements should not switch from uncontrolled to controlled (or vice versa).
Decide between using a controlled or uncontrolled valuefor the lifetime of the component.
The nature of the state is determined during the first render. It's considered controlled if the value is not `undefined`.
More info: https://fb.me/react-controlled-components

@ferishili
Copy link
Contributor Author

Thanks for the testing and your feedback, I will fix it right away

@ferishili
Copy link
Contributor Author

ferishili commented Jun 5, 2024

As an info, this error also happens in the current main branch, therefore, it would say, it is separate issue!
Here is the issue for this #636

@ferishili
Copy link
Contributor Author

Fix for MUI error is available in #652

@lkiesow
Copy link
Member

lkiesow commented Jun 5, 2024

Probably makes sense to merge #654 first

Copy link
Member

@Arnei Arnei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My testing confirms that this works, and the code looks good to.

@Arnei
Copy link
Member

Arnei commented Jun 6, 2024

All other concerns seem to have been addressed (or moved), so I'll be merging this.

@Arnei Arnei merged commit c2763c7 into opencast:main Jun 6, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:bug Something isn't working type:code-enhancement Internal improvements to the codebase type:visual-clarity Improves UI readability
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[new Admin UI] filter function does not work properly yet
5 participants