-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix filter functionality and performance #627
Conversation
This pull request is deployed at test.admin-interface.opencast.org/627/2024-06-05_12-57-07/ . |
Use Run test server using develop.opencast.org as backend:
Specify a different backend like stable.opencast.org:
It may take a few seconds for the interface to spin up. |
Right, but the problem with datepicker in the filter was not covered by the initial issue #211, |
#528 here is the issue regarding datepicker UI |
Works mostly, but not if I'm using the start date as filter. If I go to page 3 and enter a start date filter, filtering is not working. In the browser console I do get the following error:
|
Thanks for the testing and your feedback, I will fix it right away |
As an info, this error also happens in the current main branch, therefore, it would say, it is separate issue! |
Fix for MUI error is available in #652 |
Probably makes sense to merge #654 first |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
My testing confirms that this works, and the code looks good to.
All other concerns seem to have been addressed (or moved), so I'll be merging this. |
This PR fixes #211 and covers #577,
The filter functionality problem (on page > 1) has been solved by going to first page and load resources!
The performance issue has been solved by introducing debounce mechanism on loading resources.
This also covers Filter profiles!