Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix handling of long strings in modal windows and table #626

Merged
merged 1 commit into from
Jun 5, 2024

Conversation

marwyg
Copy link
Member

@marwyg marwyg commented Jun 5, 2024

Should fix: #549

This PR fixes issues with long strings in metadata for example the title. Especially the title creates problems when opening modal windows like the event details or the tables.

For testing: Please add data everywhere where you can: Users, Series, Events, etc, etc. and add long strings. The Modal Windows / Wizards should look fine if you do so. Also, when you save the data, take a look at the tables and search for your entry, the entry should cause no problems in the table. Important: It makes a difference when you put in a string with blanks or not, so maybe you want to test both cases like:

LONGDATALONGDATALONGDATALONGDATALONGDATALONGDATALONGDATALONGDATALONGDATALONGDATA
and
LONGDATA LONGDATA LONGDATA LONGDATA LONGDATA LONGDATA LONGDATA LONGDATA LONGDATA LONGDATA

@marwyg marwyg added type:bug Something isn't working bugbash labels Jun 5, 2024
Copy link
Contributor

github-actions bot commented Jun 5, 2024

This pull request is deployed at test.admin-interface.opencast.org/626/2024-06-05_10-58-44/ .
It might take a few minutes for it to become available.

Copy link
Contributor

github-actions bot commented Jun 5, 2024

Use docker or podman to test this pull request locally.

Run test server using develop.opencast.org as backend:

podman run --rm -it -p 127.0.0.1:3000:3000 ghcr.io/opencast/opencast-admin-interface:pr-626

Specify a different backend like stable.opencast.org:

podman run --rm -it -p 127.0.0.1:3000:3000 -e PROXY_TARGET=https://stable.opencast.org ghcr.io/opencast/opencast-admin-interface:pr-626

It may take a few seconds for the interface to spin up.
It will then be available at http://127.0.0.1:3000.
For more options you can pass on to the proxy, take a look at the README.md.

@marwyg
Copy link
Member Author

marwyg commented Jun 5, 2024

Please note if you test this with stable.opencast.org data, others will probably have problems with the tables when you spam in data with very long strings. Please keep this in mind and maybe change/delete the data as soon as your tests are complete.

@Arnei
Copy link
Member

Arnei commented Jun 5, 2024

In Event Details Metadata, the series selector does not show the full name when scrolling horizontally if the name of the selected series is very long

Bildschirmfoto vom 2024-06-05 14-34-44
Bildschirmfoto vom 2024-06-05 14-34-57

Copy link
Member

@Arnei Arnei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is arguably some fine tuning left to do, but I think this is already pretty good and more importantly prevents the UI from exploding all over the place.

I left another comment, but not sure whether that actually needs to be addressed in this PR.

@Arnei Arnei merged commit de92ce3 into opencast:main Jun 5, 2024
7 of 8 checks passed
@lkiesow
Copy link
Member

lkiesow commented Jun 6, 2024

This patch breaks at least the add event dialog:

Screenshot from 2024-06-06 01-05-45

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Creating long title makes UI hard to interact
3 participants