Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Submitter undefined #587

Merged
merged 1 commit into from
Jun 5, 2024
Merged

Submitter undefined #587

merged 1 commit into from
Jun 5, 2024

Conversation

lkiesow
Copy link
Member

@lkiesow lkiesow commented Jun 4, 2024

The submitter of a workflow can never be undefined, but the new interface states exactly that. The reason for that is that the interface tries to access non-existing data. This patch fixes the problem.

This fixes #359

The submitter of a workflow can never be undefined, but the new
interface states exactly that. The reason for that is that the
interface tries to access non-existing data. This patch fixes the
problem.

This fixes opencast#359
@lkiesow lkiesow added the type:bug Something isn't working label Jun 4, 2024
Copy link
Contributor

github-actions bot commented Jun 4, 2024

This pull request is deployed at test.admin-interface.opencast.org/587/2024-06-04_20-04-43/ .
It might take a few minutes for it to become available.

Copy link
Contributor

github-actions bot commented Jun 4, 2024

Use docker or podman to test this pull request locally.

Run test server using develop.opencast.org as backend:

podman run --rm -it -p 127.0.0.1:3000:3000 ghcr.io/opencast/opencast-admin-interface:pr-587

Specify a different backend like stable.opencast.org:

podman run --rm -it -p 127.0.0.1:3000:3000 -e PROXY_TARGET=https://stable.opencast.org ghcr.io/opencast/opencast-admin-interface:pr-587

It may take a few seconds for the interface to spin up.
It will then be available at http://127.0.0.1:3000.
For more options you can pass on to the proxy, take a look at the README.md.

@ziegenberg ziegenberg self-requested a review June 4, 2024 20:58
Copy link
Member

@gregorydlogan gregorydlogan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works for me

@Arnei Arnei merged commit 1522ce9 into opencast:main Jun 5, 2024
7 checks passed
@ziegenberg ziegenberg removed their request for review June 5, 2024 08:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Submitter undefined
3 participants