Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reset copy success message #586

Merged

Conversation

geichelberger
Copy link
Contributor

This resets the success message after changing the size of the embed code.

Fixes #562

This resets the success message after changing the size of the embed
code.
@geichelberger geichelberger added the type:usability Improves the UX label Jun 4, 2024
Copy link
Contributor

github-actions bot commented Jun 4, 2024

This pull request is deployed at test.admin-interface.opencast.org/586/2024-06-04_20-00-40/ .
It might take a few minutes for it to become available.

Copy link
Contributor

github-actions bot commented Jun 4, 2024

Use docker or podman to test this pull request locally.

Run test server using develop.opencast.org as backend:

podman run --rm -it -p 127.0.0.1:3000:3000 ghcr.io/opencast/opencast-admin-interface:pr-586

Specify a different backend like stable.opencast.org:

podman run --rm -it -p 127.0.0.1:3000:3000 -e PROXY_TARGET=https://stable.opencast.org ghcr.io/opencast/opencast-admin-interface:pr-586

It may take a few seconds for the interface to spin up.
It will then be available at http://127.0.0.1:3000.
For more options you can pass on to the proxy, take a look at the README.md.

@ziegenberg ziegenberg self-requested a review June 4, 2024 20:53
Copy link
Member

@ziegenberg ziegenberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! That works :)

@ziegenberg ziegenberg merged commit 98ee67b into opencast:main Jun 4, 2024
6 of 7 checks passed
@ziegenberg
Copy link
Member

Should we also clear the clipboard at the same instant? This prevents the user from accidentally pasting the wrong embed code with the wrong size.

@ziegenberg ziegenberg self-assigned this Jun 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:usability Improves the UX
Projects
None yet
Development

Successfully merging this pull request may close these issues.

changing the size of the embed code should remove the text after successfully copying to the clipboard
2 participants