Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix add-event dialog console warnings #583

Merged
merged 2 commits into from
Jun 4, 2024

Conversation

owi92
Copy link
Contributor

@owi92 owi92 commented Jun 4, 2024

Fixes a "missing key prop" and an "invalid prop type" error by adding that key and changing the prop type.
Not sure what to do about the missing i18next keys though.

Closes #550

owi92 added 2 commits June 4, 2024 18:46
So there might be hidden steps in the "add events" modal
which previously were missing a key prop, emitting an error
in the console. This is fixed by adding that prop to these
empty fragments.
This changes the prop from `boolean` to an empty
react fragment.
@owi92 owi92 added the type:code-enhancement Internal improvements to the codebase label Jun 4, 2024
Copy link
Contributor

github-actions bot commented Jun 4, 2024

Use docker or podman to test this pull request locally.

Run test server using develop.opencast.org as backend:

podman run --rm -it -p 127.0.0.1:3000:3000 ghcr.io/opencast/opencast-admin-interface:pr-583

Specify a different backend like stable.opencast.org:

podman run --rm -it -p 127.0.0.1:3000:3000 -e PROXY_TARGET=https://stable.opencast.org ghcr.io/opencast/opencast-admin-interface:pr-583

It may take a few seconds for the interface to spin up.
It will then be available at http://127.0.0.1:3000.
For more options you can pass on to the proxy, take a look at the README.md.

Copy link
Contributor

github-actions bot commented Jun 4, 2024

This pull request is deployed at test.admin-interface.opencast.org/583/2024-06-04_17-01-32/ .
It might take a few minutes for it to become available.

@ziegenberg
Copy link
Member

Not sure what to do about the missing i18next keys though.

That's a task for another issue/pull request because the i18next::translator: missingKey en-US translation <empty string> <empty string> 2 i18next.js:13:48 messages are all over the place and not limited to the add-event dialogue.

@ziegenberg ziegenberg self-requested a review June 4, 2024 20:52
@gregorydlogan gregorydlogan self-assigned this Jun 4, 2024
@gregorydlogan gregorydlogan merged commit d890746 into opencast:main Jun 4, 2024
6 of 7 checks passed
@ziegenberg ziegenberg removed their request for review June 11, 2024 16:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:code-enhancement Internal improvements to the codebase
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Errors in browser console when opening the add events dialog
3 participants