Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix misplaced themes details menu navigation buttons #563

Merged
merged 1 commit into from
Jun 5, 2024

Conversation

dennis531
Copy link
Contributor

image

Closes #551

Copy link
Contributor

github-actions bot commented Jun 4, 2024

This pull request is deployed at test.admin-interface.opencast.org/563/2024-06-04_11-02-23/ .
It might take a few minutes for it to become available.

@dennis531 dennis531 added the type:visual-clarity Improves UI readability label Jun 4, 2024
Copy link
Contributor

github-actions bot commented Jun 4, 2024

Use docker or podman to test this pull request locally.

Run test server using develop.opencast.org as backend:

podman run --rm -it -p 127.0.0.1:3000:3000 ghcr.io/opencast/opencast-admin-interface:pr-563

Specify a different backend like stable.opencast.org:

podman run --rm -it -p 127.0.0.1:3000:3000 -e PROXY_TARGET=https://stable.opencast.org ghcr.io/opencast/opencast-admin-interface:pr-563

It may take a few seconds for the interface to spin up.
It will then be available at http://127.0.0.1:3000.
For more options you can pass on to the proxy, take a look at the README.md.

@ferishili
Copy link
Contributor

@dennis531 would that be also good to nowrap the text in the nav items? In this way it looks even better. What do you think?

@dennis531
Copy link
Contributor Author

@dennis531 would that be also good to nowrap the text in the nav items? In this way it looks even better. What do you think?

white-space: nowrap; causes long texts to become completely invisible. I would suggest min-width as an alternative.

@reiferschris
Copy link
Contributor

There is still a continuous line below the "arrow" that points to the current tab that doesn't exist on the old admin-ui.

@dennis531
Copy link
Contributor Author

dennis531 commented Jun 4, 2024

Solution with min-width:
image
What do you think about the solution?

@dennis531 dennis531 force-pushed the misplaced-themes-nav-buttons branch from 4de3c1e to de9f287 Compare June 4, 2024 12:37
Copy link
Contributor

github-actions bot commented Jun 4, 2024

This pull request is deployed at test.admin-interface.opencast.org/563/2024-06-04_12-37-48/ .
It might take a few minutes for it to become available.

@dennis531 dennis531 force-pushed the misplaced-themes-nav-buttons branch from de9f287 to 8a98bc2 Compare June 4, 2024 12:39
Copy link
Contributor

github-actions bot commented Jun 4, 2024

This pull request is deployed at test.admin-interface.opencast.org/563/2024-06-04_12-39-15/ .
It might take a few minutes for it to become available.

@ziegenberg
Copy link
Member

I like the min-width solution 👍🏻

@marwyg marwyg requested review from marwyg and removed request for marwyg June 5, 2024 07:07
@Arnei
Copy link
Member

Arnei commented Jun 5, 2024

Looks like people are happy with this, merging.

@Arnei Arnei merged commit f711e2d into opencast:main Jun 5, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:visual-clarity Improves UI readability
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Misplaced themes details menu navigation buttons
5 participants