Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Properly align wizard stepper labels #522

Merged
merged 1 commit into from
Jun 4, 2024

Conversation

JulianKniephoff
Copy link
Member

Fixes #485.
Fixes #516.

@JulianKniephoff JulianKniephoff added type:bug Something isn't working type:visual-clarity Improves UI readability labels Jun 4, 2024
Copy link
Contributor

github-actions bot commented Jun 4, 2024

This pull request is deployed at test.admin-interface.opencast.org/522/2024-06-04_08-46-25/ .
It might take a few minutes for it to become available.

Copy link
Contributor

github-actions bot commented Jun 4, 2024

Use docker or podman to test this pull request locally.

Run test server using develop.opencast.org as backend:

podman run --rm -it -p 127.0.0.1:3000:3000 ghcr.io/opencast/opencast-admin-interface:pr-522

Specify a different backend like stable.opencast.org:

podman run --rm -it -p 127.0.0.1:3000:3000 -e PROXY_TARGET=https://stable.opencast.org ghcr.io/opencast/opencast-admin-interface:pr-522

It may take a few seconds for the interface to spin up.
It will then be available at http://127.0.0.1:3000.
For more options you can pass on to the proxy, take a look at the README.md.

@ziegenberg
Copy link
Member

@JulianKniephoff do we also need to fix this in src/components/shared/wizard/WizardStepperEvent.tsx ?

@JulianKniephoff
Copy link
Member Author

Here I was naively thinking that we would properly reuse code somewhere ...

Copy link
Member

@ziegenberg ziegenberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just checked, and this is fixed for creating a new series but not for creating new events.

Copy link
Contributor

github-actions bot commented Jun 4, 2024

This pull request is deployed at test.admin-interface.opencast.org/522/2024-06-04_08-54-14/ .
It might take a few minutes for it to become available.

@ziegenberg
Copy link
Member

Sadly, WizardStepperEvent.tsx and WizardStepper.tsx do not share any code, though they probably should.

Copy link
Member

@ziegenberg ziegenberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works now! :)

@ziegenberg ziegenberg merged commit df844de into opencast:main Jun 4, 2024
5 checks passed
@ziegenberg ziegenberg self-assigned this Jun 4, 2024
@JulianKniephoff JulianKniephoff deleted the align-wizard-steps branch June 4, 2024 11:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:bug Something isn't working type:visual-clarity Improves UI readability
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Visual Alignment for New Theme Wizard Steps and Buttons Visual alignment of wizard steps
2 participants