Remove the proxy server #394
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JulianKniephoff
added
the
type:code-enhancement
JulianKniephoff
force-pushed
the
remove-proxy
branch
from
0a26e24 to
04c5a92
Compare
This comment was marked as resolved.
This comment was marked as resolved.
JulianKniephoff
force-pushed
the
remove-proxy
branch
from
04c5a92 to
8aa3873
Compare
JulianKniephoff
added a commit
to JulianKniephoff/opencast-admin-interface
that referenced
this pull request
May 16, 2024
With this, the outer npm-project is finally obsolete. See the updated `README` for how to use it and the proxy server. I abstained from restructuring the project any further to keep the PR focused, but a PR that will do nothing but move things around is in the pipeline. Note, this is based on opencast#394.
JulianKniephoff
added a commit
to JulianKniephoff/opencast-admin-interface
that referenced
this pull request
May 16, 2024
With this, the outer npm-project is finally obsolete. See the updated `README` for how to use it and the proxy server. I abstained from restructuring the project any further to keep the PR focused, but a PR that will do nothing but move things around is in the pipeline. Note, this is based on opencast#394.
This was referenced May 16, 2024
Arnei
requested changes
May 16, 2024
JulianKniephoff
added a commit
to JulianKniephoff/opencast-admin-interface
that referenced
this pull request
May 16, 2024
With the refactoring of the development servers done in opencast#398 and indirectly opencast#394, there is an opportunity to boil down the project structure a bit. This PR does nothing but move files around and make the necessary changes to keep everything working. (Fingers crossed.)
JulianKniephoff
force-pushed
the
remove-proxy
branch
from
8aa3873 to
cb6074e
Compare
JulianKniephoff
force-pushed
the
remove-proxy
branch
from
cb6074e to
27e1966
Compare
Well, the outer one at least. For context: This app had two proxies: One comes with `create-react-app` as a middleware in the dev server, proxying all the requests the frontend makes (except for the static JS, CSS, etc. assets this project is generating) to some other server. In production, Opencast delivers the admin UI assets and the backend under the same URL, but in development this is not true. The development server delivers the assets and the backend is ... well it's complicated. So far you either started a static file server which was acting as a mock backend, or you started **another** proxy server that piped the requests through to an Opencast instance of your choosing while tacking on some digest authentication. Well, the dev server proxy can't (easily) do digest auth, but the fact that we insist on digest auth is a historical artifact, anyway, at least as far as I know. It can do basic auth, though, and it **is** a proxy, so it can do everything we need! This also updates the `README` appropriately and cleans it up some in general (though not completely).
JulianKniephoff
force-pushed
the
remove-proxy
branch
from
27e1966 to
d32ee40
Compare
Arnei
approved these changes
May 16, 2024
JulianKniephoff
added a commit
to JulianKniephoff/opencast-admin-interface
that referenced
this pull request
May 21, 2024
With this, the outer npm-project is finally obsolete. See the updated `README` for how to use it and the proxy server. I abstained from restructuring the project any further to keep the PR focused, but a PR that will do nothing but move things around is in the pipeline. Note, this is based on opencast#394.
JulianKniephoff
added a commit
to JulianKniephoff/opencast-admin-interface
that referenced
this pull request
May 21, 2024
With the refactoring of the development servers done in opencast#398 and indirectly opencast#394, there is an opportunity to boil down the project structure a bit. This PR does nothing but move files around and make the necessary changes to keep everything working. (Fingers crossed.)
JulianKniephoff
added a commit
to JulianKniephoff/opencast-admin-interface
that referenced
this pull request
May 22, 2024
With this, the outer npm-project is finally obsolete. See the updated `README` for how to use it and the proxy server. I abstained from restructuring the project any further to keep the PR focused, but a PR that will do nothing but move things around is in the pipeline. Note, this is based on opencast#394.
JulianKniephoff
added a commit
to JulianKniephoff/opencast-admin-interface
that referenced
this pull request
May 23, 2024
With the refactoring of the development servers done in opencast#398 and indirectly opencast#394, there is an opportunity to boil down the project structure a bit. This PR does nothing but move files around and make the necessary changes to keep everything working. (Fingers crossed.)
JulianKniephoff
added a commit
to JulianKniephoff/opencast-admin-interface
that referenced
this pull request
May 23, 2024
With the refactoring of the development servers done in opencast#398 and indirectly opencast#394, there is an opportunity to boil down the project structure a bit. This PR does nothing but move files around and make the necessary changes to keep everything working. (Fingers crossed.)
JulianKniephoff
added a commit
to JulianKniephoff/opencast-admin-interface
that referenced
this pull request
May 23, 2024
With the refactoring of the development servers done in opencast#398 and indirectly opencast#394, there is an opportunity to boil down the project structure a bit. This PR does nothing but move files around and make the necessary changes to keep everything working. (Fingers crossed.)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Well, the outer one at least. For context: This app had two proxies:
One comes with
create-react-appas a middleware in the dev server, proxying all the requests the frontend makes (except for the static JS, CSS, etc. assets this project is generating) to some other server.In production, Opencast delivers the admin UI assets and the backend under the same URL, but in development this is not true. The development server delivers the assets and the backend is ... well it's complicated.
So far you either started a static file server which was acting as a mock backend, or you started another proxy server that piped the requests through to an Opencast instance of your choosing while tacking on some digest authentication.
Well, the dev server proxy can't (easily) do digest auth, but the fact that we insist on digest auth is a historical artifact, anyway, at least as far as I know. It can do basic auth, though, and it is a proxy, so it can do everything we need!
This also updates the
READMEappropriately and cleans it up some in general (though not completely).