Make the port the client proxy proxies to configurable #346
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This one is already covered by the one below it.
That is all of them.
Also add a missing proxy. Also remove unused static data. Note that this is not a thorough cleanup of the `test` folder.
JulianKniephoff
added
the
type:code-enhancement
JulianKniephoff
force-pushed
the
configurable-proxy-port
branch
from
71ea051 to
52411fd
Compare
JulianKniephoff
changed the title
JulianKniephoff
added a commit
to JulianKniephoff/opencast-admin-interface
that referenced
this pull request
May 7, 2024
5000 is used by Control Center on macOS, so this will likely annoy at least a few developers. This is based on opencast#346, so that should be reviewed and merged first.
This comment was marked as resolved.
This comment was marked as resolved.
JulianKniephoff
force-pushed
the
configurable-proxy-port
branch
from
52411fd to
b44b796
Compare
JulianKniephoff
added a commit
to JulianKniephoff/opencast-admin-interface
that referenced
this pull request
May 8, 2024
5000 is used by Control Center on macOS, so this will likely annoy at least a few developers. This is based on opencast#346, so that should be reviewed and merged first.
|
Works. |
JulianKniephoff
added a commit
to JulianKniephoff/opencast-admin-interface
that referenced
this pull request
May 14, 2024
5000 is used by Control Center on macOS, so this will likely annoy at least a few developers. This is based on opencast#346, so that should be reviewed and merged first.
JulianKniephoff
added a commit
to JulianKniephoff/opencast-admin-interface
that referenced
this pull request
May 14, 2024
5000 is used by Control Center on macOS, so this will likely annoy at least a few developers. This is based on opencast#346, so that should be reviewed and merged first.
JulianKniephoff
added a commit
to JulianKniephoff/opencast-admin-interface
that referenced
this pull request
May 15, 2024
5000 is used by Control Center on macOS, so this will likely annoy at least a few developers. This is based on opencast#346, so that should be reviewed and merged first.
JulianKniephoff
added a commit
to JulianKniephoff/opencast-admin-interface
that referenced
this pull request
May 16, 2024
5000 is used by Control Center on macOS, so this will likely annoy at least a few developers. This is based on opencast#346, so that should be reviewed and merged first.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is based on #345, so that one needs to go in first.
Otherwise it does what it says on the tin.