Reduce state persisted by redux-persist (reopen) #310
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
One of the reasons redux-persist is causing us so many issues is that we persist the whole store. This means we persist a lot of information we really should not, either because it's info that should get cleared on page reload or because we fetch the info on page load anyway (this is not an offline app). This introduces redux-persist whitelisting, so we only persist what we explicitely declare to. From what I gather, we want to persist table filters and column arrangement, so state pertaining to that should be whitelisted. This also fixes a faulty import statement, but it likely won't have any noticable effect (since autoMergeLevel2 is not deep enough of a level to affect our nested states).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
One of the reasons redux-persist is causing us so many issues
is that we persist the whole store. This means we persist
a lot of information we really should not, either because it's
info that should get cleared on page reload or because we
fetch the info on page load anyway (this is not an offline app).
This introduces redux-persist whitelisting, so we only persist
what we explicitely declare to. From what I gather, we want
to persist table filters and column arrangement, so state
pertaining to that should be whitelisted.
This also fixes a faulty import statement, but it likely won't
have any noticable effect (since autoMergeLevel2 is not deep
enough of a level to affect our nested states).