Fix typescript complaints about tabIndex #289
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The react type definitions for the tabIndex prop want tabIndex to be a number, but we're using strings. This changes it so we use numbers. This should not change behaviour as technically using strings for tabIndex is fine, this is just to appease typescript.
owi92
approved these changes
Feb 15, 2024
There was a problem hiding this comment.
Don't see any issue with this change. And for once, glancing over the code, there really shouldn't be.
This is the last comment of my "approval bombing".
(See #242 (review) for more info on these approvals)
|
This pull request has conflicts ☹ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The react type definitions for the tabIndex prop want tabIndex to be a number, but we're using strings. This changes it so we use numbers. This should not change behaviour as technically using strings for tabIndex is fine, this is just to appease typescript.