Fix startDate table filter #287
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updates material-ui dependencies from version 4 to version 5. This affects date/time-pickers for e.g. scheduling or changing metadata dates, as well as the circles at the top of the new event/series wizards. This does change how the date/time-pickers look, because we were using the default style before which now changed. In my opinion this is for the better. Also adds back the ability to type in the date field instead of being forced into using a picker, although that does seem to cause errors. Will investigate.
Weird type issues, where the input time for the datepickers changes from string to date after being passed around. Should work now, will look for a cleaner solution when we introduce typescript to formik.
This fixes an issue where users had trouble confirming a start date filter in the event table (should also fix it in the series table). Previously, the date filter would only be confirmed if the end date was set through the calendar picker while the start date was already set. This makes it so that it does not matter which calendar picker is opened first. Furthermore, it adds the ability to confirm the filter by pressing "Enter" (all provided the both given dates are valid). This should increase usability and should also be closer to what users are used to from the old admin ui. Includes the update to material ui version 5 from opencast#277, to avoid doing this for different material ui version.
The datepicker in details metadata would only close after a lot of clicking around. This was problematic, because the set date is not actually properly confirmed until after closing. This should help with that.
For e.g. the event table, you can filter by start date, by setting two dates to filter between. This was not always working properly, because no heed was paid to the time value for those filter dates. This sets the time values for the dates, so filtering from 14.02 to 14.02 should now show all videos from 14.02 instead of no videos at all.
For e.g. the events table, users can select a filter that filters by startdate When typing in the date for the first datepicker and confirming it by pressing enter, the focus now automatically shifts to the second datepicker (and vice versa).
|
This pull request has conflicts ☹ |
|
This pull request has conflicts ☹ |
|
This pull request has conflicts ☹ |
|
This pull request has conflicts ☹ |
|
This pull request has conflicts ☹ |
|
This pull request has conflicts ☹ |
Arnei
force-pushed
the
fix-startDate-tablefilter
branch
from
c6a6743 to
b3bcc4a
Compare
|
Works for us in OC 15 :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes an issue where users had trouble confirming
a start date filter in the event table (should also fix it in
the series table).
Previously, the date filter would only be confirmed if
the end date was set through the calendar picker while
the start date was already set. This makes it so that it
does not matter which calendar picker is opened first.
Furthermore, it adds the ability to confirm the filter by
pressing "Enter" (all provided the both given dates are
valid). This should increase usability and should also be
closer to what users are used to from the old admin ui.
Includes the update to material ui version 5 from #277,
to avoid doing this for different material ui version.