Avoid crashing by not throwing error #281
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Potentially controversial fix intended to keep nodemon from crashing. Instead of having the proxy server throw certain kinds of errors, this changes it to merely logging them. The throwing in and of itself is likely not the root cause of the nodemon crashing issue, but removing it seems to alleviate the issue nonetheless. I'm not certain on what we should ideally do with the kinds of errors that were previously thrown in the first place though.
|
I've hit this lots. Imo this makes sense to me. |
|
Since this is gonna help with developing, let's get this in. We should get at the root cause of this problem some day, but better than nothing... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #267
Potentially controversial fix intended to keep nodemon from crashing. Instead of having the proxy server
throw certain kinds of errors, this changes it to merely logging them. The throwing in and of itself is likely not the root cause of the nodemon crashing issue, but removing it seems to alleviate the issue nonetheless.
I'm not certain on what we should ideally do with the kinds of errors that were previously thrown in the first place though.