Remove frontend table sorting #272
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Removes the faulty frontend table sorting algorithm in favor of letting the backend do the sorting. The frontend sorting algorithm would only take the elements on the current page into account, meaning as soon as your table spans multiple pages the sorting would be faulty. Instead, we now immediately query the backend with a sorting parameter, same as in the old admin ui. Since we're polling every couple seconds anyway, this really just speeds things up a little bit to meet user expectations.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #123, Resolves #60, Resolves #59.
Removes the faulty frontend table sorting algorithm in favor of letting the backend do the sorting.
The frontend sorting algorithm would only take
the elements on the current page into account, meaning as soon as your table spans multiple pages the sorting would be faulty.
Instead, we now immediately query the backend with a sorting parameter, same as in the old admin ui. Since we're polling every couple seconds anyway, this really just speeds things up a little bit to meet user expectations.