Dont store scheduling source as date in redux #268
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
While storing dates as date objects in redux does not necessarily break anything, it can interfere with some features (persisting, debugging) and lead to bad practices (for an encompassing discussion see reduxjs/redux-toolkit#456). This changes the scheduling info fetching method to store dates as strings
gregorydlogan
requested changes
Feb 22, 2024
app/src/thunks/eventDetailsThunks.ts
Outdated
| @@ -871,12 +871,12 @@ export const fetchSchedulingInfo = (eventId) => async (dispatch, getState) => { | |||
| const source = { | |||
| ...schedulingResponse, | |||
| start: { | |||
| date: startDate, | |||
| date: schedulingResponse.start, | |||
There was a problem hiding this comment.
So, for me these render as (DD/MM/YY HH:MM) when the modal opens, but then clicking on them to change them switches to the long date (Feburary 22nd 11pm). This is quite confusing IMO - I would not expect the format to change when clicking in.
|
This pull request has conflicts ☹ |
…-scheduling-source-as-date
|
This pull request has conflicts ☹ |
…-scheduling-source-as-date
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While storing dates as date objects in redux does not necessarily break anything, it can interfere with some features (persisting, debugging) and lead to bad practices (for an encompassing discussion see reduxjs/redux-toolkit#456).
This changes the scheduling info fetching method to store dates as strings.