Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unused warning during bulk delete #1049

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

Arnei
Copy link
Member

@Arnei Arnei commented Jan 9, 2025

This patch removes a warning in the bulk delete modal that claims the user is not authorized.
Removing this for two reasons:

  1. The warning claims to have done an authorization check. That check is never performed, but the warning is always displayed nonetheless.
  2. Users currently cannot select events if they don't have write access on them anyway (they don't show up in the events table in the first place), so there is no need to perform such an authorization check in the first place.

How to test this

Can be tested as usual.

This patch removes a warning in the bulk delete
modal that claims the user is not authorized.
Removing this for two reasons:
1. The warning claims to have done an authorization
check. That check is never performed, but the
warning is always displayed nonetheless.
2. Users currently cannot select events if they don't
have write access on them anyway (they don't
show up in the events table in the first place),
so there is no need to perform such an
authorization check in the first place.
@Arnei Arnei added the type:bug Something isn't working label Jan 9, 2025
Copy link
Contributor

github-actions bot commented Jan 9, 2025

Use docker or podman to test this pull request locally.

Run test server using develop.opencast.org as backend:

podman run --rm -it -p 127.0.0.1:3000:3000 ghcr.io/opencast/opencast-admin-interface:pr-1049

Specify a different backend like stable.opencast.org:

podman run --rm -it -p 127.0.0.1:3000:3000 -e PROXY_TARGET=https://stable.opencast.org ghcr.io/opencast/opencast-admin-interface:pr-1049

It may take a few seconds for the interface to spin up.
It will then be available at http://127.0.0.1:3000.
For more options you can pass on to the proxy, take a look at the README.md.

Copy link
Contributor

github-actions bot commented Jan 9, 2025

This pull request is deployed at test.admin-interface.opencast.org/1049/2025-01-09_11-51-49/ .
It might take a few minutes for it to become available.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant