Properly hide Tobira tab #1048
Merged
Properly hide Tobira tab #1048
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In the event details tabs, the Tobira tab is showing up even if Tobira is not configured. This patch should fix that.
|
Use Run test server using develop.opencast.org as backend: Specify a different backend like stable.opencast.org: It may take a few seconds for the interface to spin up. |
|
This pull request is deployed at test.admin-interface.opencast.org/1048/2025-01-09_13-27-29/ . |
owi92
reviewed
Jan 9, 2025
owi92
suggested changes
Jan 9, 2025
- Makes sure that a web request is actually send, so that status and error fields will contain useful values. - Changes the check to include "status === failed". - Changes the check back to checking explicitly for a 503 response, instead of assuming that the service is unavailable if the error is undefined.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the event details tabs, the Tobira tab is showing up even if Tobira is not configured. This patch should fix that.
How to test this
Ideally this is tested by someone with a Tobira setup, so that they can confirm that the tobira tab still correctly shows up if Tobira is indeed configured. Properly setting up Tobira is somewhat involved, so I'll direct all questions about that to the Tobira docs and the main Tobira developers.