Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update react-router to 7.1.1 #1043

Merged
merged 2 commits into from
Jan 15, 2025
Merged

Conversation

Arnei
Copy link
Member

@Arnei Arnei commented Jan 6, 2025

Supersedes #1035.

Updates the dependency "react-router-dom" to "react-router" (package restructuring happened).

@Arnei Arnei added the type:dependencies Pull requests that update a dependency file label Jan 6, 2025
@Arnei Arnei force-pushed the update-react-router-7.1.1 branch from 816141b to 544b195 Compare January 6, 2025 09:54
Copy link
Contributor

github-actions bot commented Jan 6, 2025

This pull request has conflicts ☹
Please resolve those so we can review the pull request.
Thanks.

Copy link
Contributor

github-actions bot commented Jan 6, 2025

Use docker or podman to test this pull request locally.

Run test server using develop.opencast.org as backend:

podman run --rm -it -p 127.0.0.1:3000:3000 ghcr.io/opencast/opencast-admin-interface:pr-1043

Specify a different backend like stable.opencast.org:

podman run --rm -it -p 127.0.0.1:3000:3000 -e PROXY_TARGET=https://stable.opencast.org ghcr.io/opencast/opencast-admin-interface:pr-1043

It may take a few seconds for the interface to spin up.
It will then be available at http://127.0.0.1:3000.
For more options you can pass on to the proxy, take a look at the README.md.

Copy link
Contributor

github-actions bot commented Jan 6, 2025

This pull request is deployed at test.admin-interface.opencast.org/1043/2025-01-06_11-03-52/ .
It might take a few minutes for it to become available.

Updates the dependency "react-router-dom" to
"react-router".
Copy link
Contributor

github-actions bot commented Jan 6, 2025

This pull request has conflicts ☹
Please resolve those so we can review the pull request.
Thanks.

@Arnei Arnei mentioned this pull request Jan 14, 2025
@Arnei Arnei merged commit ce64009 into opencast:main Jan 15, 2025
5 checks passed
@JulianKniephoff
Copy link
Member

Somehow—I don't know how, yet—this breaks filtering. If you click on a series title in the series table, for example, you are redirected to the events table, the filter appears for a moment, and then disappears again. :/

@Arnei
Copy link
Member Author

Arnei commented Jan 23, 2025

That is weird o.O. Would you like to open a revert?

@JulianKniephoff
Copy link
Member

I would love to know why this happens first, but if I can't in a reasonable time, I will. Feel free to beat me to it, though, if you are impatient. :D

Arnei added a commit to Arnei/opencast-admin-interface that referenced this pull request Jan 23, 2025
Reverts PR opencast#1043. The PR seems to have caused
problems with table filtering, which are fixed by
reverting it. The issue in question is that clicking
on a series name in the series table will not result
in a properly filtered events table anymore.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants